Bug in MathUtility Multiply, Divide, Modulo methods

GJ Roelofs 2 years ago updated by Lazlo Bonin (Lead Developer) 1 year ago 5

In these methods the `y` parameter is used for the RHS argument where the `x` argument should be used.

See below:

Unity Version:
Peek Version:

Dear GJ Roelofs,

Thanks for submitting this report. I will pass it on to our lead developer.

Kind regards,

Hasan from Ludiq

Fixed (Unreleased)

Hi GJ Roelofs,

Thanks for the report. This will be fixed in the next version.

However, I cannot recommend relying on undocumented Ludiq Core utility methods in your project. These are meant for our own internal use, not as a public API. They might get removed or changed in the future.

I completely agree, and I'm glad you think that you consider certain API internal!

Would you terribly mind using `internal` instead of `public` then and using the Friendly Assembly setup to only expose them to your assemblies? The bleed-through of internal API in the form of extension methods is very annoying, especially if those methods exist on core classes.

See: https://docs.microsoft.com/en-us/dotnet/api/system.runtime.compilerservices.internalsvisibletoattribute?view=netframework-4.8
This is fully supported by Unity3D and assembly definitions.

Per example, this is my view when I code complete on `Divide`. There are no less than 4 static extensions that implement `Divide()` for `Vector3`, and code completion gives me no hint as to which will be the one from the approved library.